Skip to content

Merge branch 'main' of github.com:Shopify/dawn into v15 #81

Merge branch 'main' of github.com:Shopify/dawn into v15

Merge branch 'main' of github.com:Shopify/dawn into v15 #81

Triggered via push July 4, 2024 10:08
Status Failure
Total duration 37s
Artifacts

ci.yml

on: push
Theme Check
27s
Theme Check
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 38 warnings, and 12 notices
sections/main-product.liquid#L687
[UndefinedObject] Undefined object `variant_i`
snippets/product-variant-picker.liquid#L116
[SyntaxError] 'endunless' is not a valid delimiter for if tags. use endif
layout/password.liquid#L179
[AssetPreload] For better performance, prefer using the preload_tag filter
layout/password.liquid#L184
[AssetPreload] For better performance, prefer using the preload_tag filter
layout/theme.liquid#L398
[LiquidTag] Use {% liquid ... %} to write multiple tags
layout/theme.liquid#L258
[AssetPreload] For better performance, prefer using the preload_tag filter
layout/theme.liquid#L263
[AssetPreload] For better performance, prefer using the preload_tag filter
sections/bulk-quick-order-list.liquid#L5
[NestedSnippet] Too many nested snippets
sections/bulk-quick-order-list.liquid#L5
[NestedSnippet] Too many nested snippets
sections/bulk-quick-order-list.liquid#L5
[NestedSnippet] Too many nested snippets
sections/bulk-quick-order-list.liquid#L5
[NestedSnippet] Too many nested snippets
sections/bulk-quick-order-list.liquid#L5
[NestedSnippet] Too many nested snippets
sections/bulk-quick-order-list.liquid#L5
[NestedSnippet] Too many nested snippets
sections/collage.liquid#L95
[LiquidTag] Use {% liquid ... %} to write multiple tags
sections/featured-collection.liquid#L97
[LiquidTag] Use {% liquid ... %} to write multiple tags
sections/featured-product.liquid#L468
[UnusedAssign] `seo_media` is never used
sections/main-cart-footer.liquid#L67
[LiquidTag] Use {% liquid ... %} to write multiple tags
sections/main-collection-banner.liquid#L27
[ImgLazyLoading] Use loading="eager" for images visible in the viewport on load and loading="lazy" for others
sections/main-collection-product-grid.liquid#L153
[LiquidTag] Use {% liquid ... %} to write multiple tags
sections/main-collection-product-quick-buy.liquid#L239
[LiquidTag] Use {% liquid ... %} to write multiple tags
sections/main-product.liquid#L731
[UnusedAssign] `seo_media` is never used
sections/main-search.liquid#L257
[LiquidTag] Use {% liquid ... %} to write multiple tags
sections/predictive-search.liquid#L145
[ImgLazyLoading] Use loading="eager" for images visible in the viewport on load and loading="lazy" for others
sections/quick-order-list.liquid#L23
[NestedSnippet] Too many nested snippets
sections/quick-order-list.liquid#L23
[NestedSnippet] Too many nested snippets
sections/quick-order-list.liquid#L23
[NestedSnippet] Too many nested snippets
sections/quick-order-list.liquid#L23
[NestedSnippet] Too many nested snippets
sections/quick-order-list.liquid#L23
[NestedSnippet] Too many nested snippets
sections/quick-order-list.liquid#L23
[NestedSnippet] Too many nested snippets
sections/related-products.liquid#L38
[LiquidTag] Use {% liquid ... %} to write multiple tags
snippets/cart-drawer.liquid#L496
[LiquidTag] Use {% liquid ... %} to write multiple tags
snippets/header-drawer.liquid#L24
[LiquidTag] Use {% liquid ... %} to write multiple tags
snippets/header-dropdown-menu.liquid#L10
[LiquidTag] Use {% liquid ... %} to write multiple tags
snippets/header-mega-menu.liquid#L10
[LiquidTag] Use {% liquid ... %} to write multiple tags
snippets/product-variant-options.liquid#L1
[UnusedSnippet] This snippet is not used
snippets/quick-order-list.liquid#L177
[LiquidTag] Use {% liquid ... %} to write multiple tags
snippets/quick-order-product-row.liquid#L1
[UnusedSnippet] This snippet is not used
templates/gift_card.liquid#L96
[AssetPreload] For better performance, prefer using the preload_tag filter
templates/gift_card.liquid#L101
[AssetPreload] For better performance, prefer using the preload_tag filter
Theme Check
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
sections/bulk-quick-order-list.liquid#L7
[SchemaJsonFormat] JSON formatting could be improved
sections/collapsible-content.liquid#L109
[SchemaJsonFormat] JSON formatting could be improved
sections/contact-form.liquid#L136
[SchemaJsonFormat] JSON formatting could be improved
sections/email-signup-banner.liquid#L139
[SchemaJsonFormat] JSON formatting could be improved
sections/featured-blog.liquid#L189
[SchemaJsonFormat] JSON formatting could be improved
sections/image-banner.liquid#L169
[SchemaJsonFormat] JSON formatting could be improved
sections/image-with-text.liquid#L110
[SchemaJsonFormat] JSON formatting could be improved
sections/main-product.liquid#L687
[SpaceInsideBraces] Space missing after ':'
sections/multirow.liquid#L110
[SchemaJsonFormat] JSON formatting could be improved
sections/newsletter.liquid#L117
[SchemaJsonFormat] JSON formatting could be improved
sections/page.liquid#L38
[SchemaJsonFormat] JSON formatting could be improved
sections/rich-text.liquid#L97
[SchemaJsonFormat] JSON formatting could be improved