Change default format from jsonv2 to geocodejson
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define GeocodeJSON json schema for both `search` and `lookup` endpoints and clean now useless schemas. Refs: #2
Reference GeoJSON schema to define the GeocodeJSON one. Put it in a standalone file and reference it inside the OpenAPI spec. Refs: #2
Add `make validate` utility using `@apidevtools/swagger-cli` to validate OpenAPI spec. Add `make bundle` utility to dereference and minify OpenAPI spec and JSON schema. New dependency: `npx`. Refs: #2
Now checksums are computed (pre-commit) and checked (pre-push) for both OpenAPI spec and JSON schema and their minified versions. Refs: #2
Swagger UI now loads the minified OpenAPI spec. Swagger Editor (latest version) doesn't support custom spec passed with envars or url parameters (see [swagger-editor/issues/4411](swagger-api/swagger-editor#4411)). Refs: #2
jenkin
changed the title
jsonv2 to geocodejsonjsonv2 to geocodejson
Move OSM specific attributes out of GeocodeJSON schema. Refs: #2
|
This work is leading to define and publish JSON schemas for three formats: geocodejson, semver and geohash. For geocodejson I opened an issue and forked the official repo ready for a PR. For semver I opened an issue on the official website repo. For geohash I sent an email to the official contant point. |
|
We are waiting for geocoders/geocodejson-spec#25 but all schema dependencies are now published by https://github.com/jenkin/json-schema-bricks. So I'll merge this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define GeocodeJSON json schema for both
searchandlookupendpoints and clean now useless schemas.Add automatic validation, dereferencing and minification tools.
Refs: #2