fix: Sync related bug (#147)

* fix: Do not touch auto generated fields * fix: Add missing /api segment in route * fix: Call trim for all cases for safekeeping
sparcs-kaist · Dec 10, 2024 · 7d27346 · 7d27346
1 parent 9f9119c
commit 7d27346
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 13 deletions.
diff --git a/src/modules/sync/sync.controller.ts b/src/modules/sync/sync.controller.ts
@@ -11,7 +11,7 @@ import { toJsonSemester } from 'src/common/interfaces/serializer/semester.serial
 import { SyncScholarDBService } from './syncScholarDB.service';
 import { SyncTakenLectureService } from './syncTakenLecture.service';
 
-@Controller('sync')
+@Controller('api/sync')
 export class SyncController {
   constructor(
     private readonly syncScholarDBService: SyncScholarDBService,

diff --git a/src/modules/sync/syncScholarDB.service.ts b/src/modules/sync/syncScholarDB.service.ts
@@ -226,7 +226,7 @@ export class SyncScholarDBService {
         const foundLecture = existingLectures.find(
           (l) =>
             l.code === lecture.subject_no &&
-            l.class_no === lecture.lecture_class.trim(),
+            l.class_no.trim() === lecture.lecture_class.trim(),
         );
         const course_id = courseMap.get(lecture.old_no)?.id;
         if (!course_id)
@@ -529,7 +529,7 @@ export class SyncScholarDBService {
       const lecture = existingLectures.find(
         (l) =>
           l.code === time.subject_no &&
-          l.class_no === time.lecture_class.trim(),
+          l.class_no.trim() === time.lecture_class.trim(),
       );
       if (!lecture) {
         result.skipped.push({

diff --git a/src/prisma/repositories/sync.repository.ts b/src/prisma/repositories/sync.repository.ts
@@ -101,8 +101,6 @@ export class SyncRepository {
         type_en: data.type_en,
         title: data.title,
         title_en: data.title_en,
-        title_en_no_space: data.title_en.replace(/\s/g, ''),
-        title_no_space: data.title.replace(/\s/g, ''),
         summury: '',
         grade_sum: 0,
         load_sum: 0,
@@ -120,8 +118,6 @@ export class SyncRepository {
       where: { id },
       data: {
         ...data,
-        title_no_space: data.title && data.title.replace(/\s/g, ''),
-        title_en_no_space: data.title_en && data.title_en.replace(/\s/g, ''),
       },
     });
   }
@@ -159,8 +155,6 @@ export class SyncRepository {
       data: {
         ...data,
         deleted: false,
-        title_no_space: data.title.replace(/\s/g, ''),
-        title_en_no_space: data.title_en.replace(/\s/g, ''),
         grade_sum: 0,
         load_sum: 0,
         speech_sum: 0,

diff --git a/src/prisma/schema.prisma b/src/prisma/schema.prisma
@@ -383,8 +383,8 @@ model subject_course {
   load                                                                                                             Float
   speech                                                                                                           Float
   latest_written_datetime                                                                                          DateTime?                                  @db.DateTime(0)
-  title_no_space                                                                                                   String                                     @db.VarChar(100)
-  title_en_no_space                                                                                                String                                     @db.VarChar(200)
+  title_no_space                                                                                                   String                                     @default(dbgenerated()) @db.VarChar(100)
+  title_en_no_space                                                                                                String                                     @default(dbgenerated()) @db.VarChar(200)
   main_relatedcoursedailyuserfeed                                                                                  main_relatedcoursedailyuserfeed[]
   planner_futureplanneritem                                                                                        planner_futureplanneritem[]
   review                                                                                                           review_review[]
@@ -513,8 +513,8 @@ model subject_lecture {
   class_title_en                  String?                              @db.VarChar(100)
   common_title                    String?                              @db.VarChar(100)
   common_title_en                 String?                              @db.VarChar(100)
-  title_no_space                  String                               @db.VarChar(100)
-  title_en_no_space               String                               @db.VarChar(200)
+  title_no_space                  String                               @default(dbgenerated()) @db.VarChar(100)
+  title_en_no_space               String                               @default(dbgenerated()) @db.VarChar(200)
   main_reviewwritedailyuserfeed   main_reviewwritedailyuserfeed[]
   planner_takenplanneritem        planner_takenplanneritem[]
   review                          review_review[]