Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for turning off signal handler that prints backtrace #543

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VictorYing
Copy link

@VictorYing VictorYing commented Nov 22, 2024

Adjusted constructor API so that modelers can disable Sparta's signal handlers, since it conflicts with other framework like SST. No change to default behavior.

Added option to disable backtrace (conflicts with other framework like SST)
@klingaard
Copy link
Member

klingaard commented Nov 23, 2024

Hi Victor, thank you for the submission!

Instead of adding a new construction parameter to the Simulation class, add this behavior to SimulationConfiguration.

Then, move the backtrace_ set handler calls to this function of Simulation:

if(sim_config_->install_signals_handlers) {
   ...
}

Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants