Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debugging support for DAG #536

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Add debugging support for DAG #536

merged 4 commits into from
Oct 30, 2024

Conversation

furuame
Copy link
Member

@furuame furuame commented Oct 25, 2024

It would make modelers' lives easier to debug Event ordering by just enabling scheduler debug logger -l scheduler debug 1.

I implicitly turn on the early cycle detection when the debug logger is enabled. I think that would be useful since that seems never be enabled 🤔 There is a method to turn it on but you would need to re-compile the software during debugging. Let me know your thoughts.

@furuame furuame added the component: sparta Issue is related to sparta framework label Oct 25, 2024
@furuame furuame self-assigned this Oct 25, 2024
@furuame
Copy link
Member Author

furuame commented Oct 25, 2024

I just saw the test failures. I should keep the method to keep backward compatibility.

Copy link
Member

@klingaard klingaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@furuame furuame merged commit d63b335 into master Oct 30, 2024
8 checks passed
@furuame furuame deleted the zhenw/add-dag-debug-messages branch October 30, 2024 01:30
github-actions bot pushed a commit that referenced this pull request Oct 30, 2024
* Add debugging support for DAG

* Revert "Add debugging support for DAG"

This reverts commit 7ba728f.

* Add debugging support for DAG

* Reset DAG after scheduler being reset d63b335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: sparta Issue is related to sparta framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants