Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NameError: name 'ScheduleLineElement' is not defined error in Argos #500

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix NameError: name 'ScheduleLineElement' is not defined error in Argos #500

merged 2 commits into from
May 3, 2024

Conversation

bdutro
Copy link
Contributor

@bdutro bdutro commented May 2, 2024

Fixes the following error that can occur when advancing Argos quickly:

NameError: name 'ScheduleLineElement' is not defined

@bdutro bdutro requested a review from klingaard May 2, 2024 20:45
bdutro
bdutro commented May 2, 2024
View reviewed changes
helios/pipeViewer/pipe_view/model/schedule_element.py
Comment on lines +392 to +393
from .element_value import FakeElementValue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FakeElementValue is only actually used in this function. By importing it here, we avoid a circular import dependency with element_value.py.

klingaard
klingaard approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@klingaard klingaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool -- I came across this error every now and then, but found it to be a "stupid" on my end.

@bdutro bdutro merged commit 3092846 into master May 3, 2024
8 checks passed
@bdutro bdutro deleted the dev/bdutro/argos-fix-schedule-line-element-error branch May 3, 2024 14:30
github-actions bot pushed a commit that referenced this pull request May 3, 2024
@bdutro
[ci skip] Fix NameError: name 'ScheduleLineElement' is not defined er…
2b4337d 
…ror in Argos (#500)

* Fix NameError: name 'ScheduleLineElement' is not defined error in Argos

* Remove unused import to fix Python linter errors 3092846
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klingaard klingaard klingaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdutro @klingaard