Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in ability to specify a content_width for ColumnViews #495

Conversation

bgrayson-mips
Copy link
Contributor

No description provided.

@klingaard klingaard added the component: pipeViewer Issue is related to the Helios Pipeline Viewer label Apr 25, 2024
@@ -266,6 +266,7 @@ def __init__(self,
spacing,
margins,
include_detail_column : bool,
content_width : int,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To allow backward compatibility, can you swap the order of the new param with time_offset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got them all -- can you double-check, since I don't know python?

@bgrayson-mips
Copy link
Contributor Author

I can't merge this, since I don't have write access. Could one of you two do it? Thx.

@bdutro bdutro merged commit d2d1a4f into sparcians:master Apr 29, 2024
8 checks passed
@bdutro
Copy link
Contributor

bdutro commented Apr 29, 2024

Done.

github-actions bot pushed a commit that referenced this pull request Apr 29, 2024
…#495)

* Added in ability to specify a content_width

* Reordered new arg to maintain backwards compatibility, per comment d2d1a4f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pipeViewer Issue is related to the Helios Pipeline Viewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants