Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused member ev_producing_event_(SkeletonPipeline) #474

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

lhtin
Copy link
Contributor

@lhtin lhtin commented Feb 27, 2024

The class member ev_producing_event_ of Producer is unused, the 1 cycle delay is configured in Consumer consumer_in_port_ member like below. Removing it to avoid misunderstanding.

class Consumer : public sparta::Unit
{
    // Consumer's InPort to get data
    sparta::DataInPort<uint32_t> consumer_in_port_{&unit_port_set_, "consumer_in_port", 1};
}

Copy link
Member

@klingaard klingaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think I had an intention of using this event to show how you can delay internal work in the producer. But we have other examples of that elsewhere.

Thanks for the fix.

@klingaard klingaard merged commit 64e119f into sparcians:master Mar 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants