Scoreboard View Fix #468
Merged
Scoreboard View Fix #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klingaard
reviewed
Jan 18, 2024
klingaard
reviewed
Jan 19, 2024
…t instead of searching for ancestor/root
klingaard
reviewed
Jan 20, 2024
| @@ -152,7 +152,7 @@ class ExeUnit : public sparta::Unit | |||
| my_scoreboard_view_.reset | |||
| (new sparta::ScoreboardView(getContainer()->getName(), // ALU0, ALU1, LSU, FPU, etc | |||
| sb_unit_type_, // integer, fp, vector | |||
| getContainer())); // Used to find the Scoreboard | |||
| getContainer()->getRoot())); // Used to find the Scoreboard | |||
There was a problem hiding this comment.
Technically you can call getRoot here, but this is a tester, no harm. Also, did it not work with just getContainer?
There was a problem hiding this comment.
getContainer didn't work. I think it was too far down the tree, so the scoreboard was above.
klingaard
approved these changes
Jan 20, 2024
klingaard
pushed a commit
to riscv-software-src/riscv-perf-model
that referenced
this pull request
Feb 7, 2024
This PR adds issue queue modeling to Olympia, by allowing users to define the number of issue queues, which execution units map to which issue queues, and which target pipes are supported for each execution unit. Regressions will fail until we merge [scoreboard fix](sparcians/map#468) in Sparta. Old flow: dispatch -> executepipe->execute New flow: dispatch -> issue queue -> executepipe -> execute --------- Signed-off-by: Aaron Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scoreboard view is hardcoded to look for scoreboards along
core.*only. I hit this bug when working on development work for Olympia, where our unit tests initialize a simulation without a core node, thus resulting in the sparta assert triggering. The proposed fix is to check if thecpu_nodeis null, then use the root node to search for scoreboards. An additional test for a cpu not named "core" is added to verify these changes.