Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close broken connections #71

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Close broken connections #71

merged 2 commits into from
Dec 1, 2024

Conversation

andig
Copy link
Contributor

@andig andig commented Dec 1, 2024

Close broken connections so they will be reopened on next operation.

Depends on #68. Refs evcc-io/evcc#17446 (comment).

Note: I've removed the receive error annotation since send doesn't add one either.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.68%. Comparing base (6020765) to head (bf957e7).

Files with missing lines Patch % Lines
rscp/client.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
- Coverage   47.83%   47.68%   -0.15%     
==========================================
  Files          28       28              
  Lines        1315     1319       +4     
==========================================
  Hits          629      629              
- Misses        652      656       +4     
  Partials       34       34              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spali spali merged commit fb6e8bc into spali:master Dec 1, 2024
6 checks passed
@andig andig deleted the feat/close-conn branch December 1, 2024 19:41
@spali spali added the enhancement New feature or request label Dec 1, 2024
@spali
Copy link
Owner

spali commented Dec 1, 2024

@andig Thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants