-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-856: WCS should roundtrip with sufficient accuracy #1273
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
- Coverage 76.21% 76.10% -0.11%
==========================================
Files 115 115
Lines 7631 7639 +8
==========================================
- Hits 5816 5814 -2
- Misses 1815 1825 +10 ☔ View full report in Codecov by Sentry. |
8da6df5
to
c4156a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think I missed the part of this test that checks that things round trip? This WCS contains only the v2v3tosky bit, and not the CRDS distortion bit. That's good since it makes for an easier unit test but bad since it won't catch the only case we have had problems here so far, where the failure to round trip was in the CRDS distortion file. Do we intend to check the CRDS reference files as well? I note that the bounding box is inconsistent with the size of the image, and that we're pretending that the sizes of the pixels are ~1". I think that's likely fine. romanisim has some code for making up a "fake" distortion function here |
@nden , do you plan to go forward with this in the future, or should we merge now? |
This requires a change in gwcs which I haven't had time to complete. I'll take it out of Draft when it's ready. |
77d1f40
to
7a58ca0
Compare
7a58ca0
to
6144111
Compare
Resolves RCAL-856
Closes #1272
This PR is the last one in a chain of PRs aiming to fix roundtripping of WCS transforms.
The only change here is to test data, ensuring the WCS is consistent and the inverse is wihtin the bounding box.
The order the PRs should be merged is
Checklist
CHANGES.rst
under the corresponding subsection