Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a multi-dimensional PixelFrame #461

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Cadair
Copy link
Collaborator

@Cadair Cadair commented Jun 23, 2023

I often find myself doing cf.CoordinateFrame(3, ["PIXEL", "PIXEL", "PIXEL"], unit=[u.pix, u.pix, u.pix], ...) to generate an input frame to a single stage "pixel to world" type WCS.

Having a shortcut, designed to be an input frame where you aren't going to have a compound frame or anything as input, like this PixelFrame would let you do PixelFrame(3) and get the same result.

I do think that Frame2D feels somewhat like a special case of this new PixelFrame, but not sure if it's worth deprecating Frame2D or not.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.04 ⚠️

Comparison is base (8ded81c) 87.25% compared to head (335619d) 87.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
- Coverage   87.25%   87.21%   -0.04%     
==========================================
  Files          23       23              
  Lines        3820     3824       +4     
==========================================
+ Hits         3333     3335       +2     
- Misses        487      489       +2     
Impacted Files Coverage Δ
gwcs/coordinate_frames.py 94.93% <50.00%> (-0.44%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant