[Merged by Bors] - Support poet certificates #5221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
force-pushed
the
support-poet-certificates
branch
from
af7311b to
2540b1e
Compare
|
bors try |
tryBuild failed: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5221 +/- ##
=========================================
- Coverage 80.8% 80.7% -0.1%
=========================================
Files 287 290 +3
Lines 29905 30525 +620
=========================================
+ Hits 24182 24659 +477
- Misses 4140 4234 +94
- Partials 1583 1632 +49 ☔ View full report in Codecov by Sentry. |
|
bors try |
poszu
force-pushed
the
support-poet-certificates
branch
from
7c1cd15 to
f1f44be
Compare
poszu
force-pushed
the
support-poet-certificates
branch
from
acd63d6 to
a2893dc
Compare
|
bors try |
poszu
force-pushed
the
support-poet-certificates
branch
from
c19d390 to
ffd77d0
Compare
tryBuild failed: |
|
bors try |
tryBuild failed: |
|
bors try |
fasmat
reviewed
Apr 24, 2024
fasmat
approved these changes
Apr 26, 2024
Searching for positioning ATX is slow because: - the SQL query is slow - it usually happens at the same time as many ATXs are being inserted into the DB (the poet CG)
fasmat
reviewed
May 22, 2024
|
Bors try |
fasmat
reviewed
May 22, 2024
fasmat
reviewed
May 22, 2024
| log.ZShortStringer("smesherID", nodeID), | ||
| ) | ||
| challenge []byte, | ||
| logger *zap.Logger, |
There was a problem hiding this comment.
Why is this logger passed as argument? poetClient has a logger field?
There was a problem hiding this comment.
Because it gets a logger already enriched with additional fields like context and smesher ID.
There was a problem hiding this comment.
Not part of this PR, but it doesn't make sense how we handle loggers and contexts to me at the moment. Ideally we would have a situation like this:
ctx = log.WithFields(ctx, log.ZShortStringer("smesherID", nodeID) // probably already in node.go and passed to component
// ... some code to determine which poet to use
ctx = log.WithFields(ctx, zap.String("poet", client.Address())
// ... only pass ctx to child functions
// within child function
logger := c.log.WithOptions(log.ZContext(ctx))
logger.Info("some message") // prints message + smesherID field + poet address fieldRight now we are passing both the logger and the context around and store information that should be added to logs in both the context and local loggers...
Wdyt?
tryBuild succeeded: |
fasmat
approved these changes
May 23, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 23, 2024
## Motivation Closes #5204 ## Changes Added support for registering in the poet services using a certificate instead of PoW. It still supports both ways and will fallback to the PoW if: - certificate is not available (couldn't certify) - the poet service doesn't support certificates There is a new interface in `activation` package `certifierService` that provides a generic way to obtain a certificate for a given poet. It abstracts away the fact that a POST proof is used - it is hidden in `certifierServiceClient`, which could in future have different implementations for other poet services. Changed the `initial_post` table to `post` as it now holds the latest POST proof. Relying solely on initial post proof OR an existing ATX could not work in case of a checkpoint (in fact this way it failed systests). ## Test Plan - added UTs - added system tests
|
Build failed: |
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
May 23, 2024
## Motivation Closes #5204 ## Changes Added support for registering in the poet services using a certificate instead of PoW. It still supports both ways and will fallback to the PoW if: - certificate is not available (couldn't certify) - the poet service doesn't support certificates There is a new interface in `activation` package `certifierService` that provides a generic way to obtain a certificate for a given poet. It abstracts away the fact that a POST proof is used - it is hidden in `certifierServiceClient`, which could in future have different implementations for other poet services. Changed the `initial_post` table to `post` as it now holds the latest POST proof. Relying solely on initial post proof OR an existing ATX could not work in case of a checkpoint (in fact this way it failed systests). ## Test Plan - added UTs - added system tests
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5204
Changes
Added support for registering in the poet services using a certificate instead of PoW. It still supports both ways and will fallback to the PoW if:
There is a new interface in
activationpackagecertifierServicethat provides a generic way to obtain a certificate for a given poet. It abstracts away the fact that a POST proof is used - it is hidden incertifierServiceClient, which could in future have different implementations for other poet services.Changed the
initial_posttable topostas it now holds the latest POST proof. Relying solely on initial post proof OR an existing ATX could not work in case of a checkpoint (in fact this way it failed systests).Test Plan