v2alpha1: Add vesting, vault and drain vault contents to Transaction #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
reviewed
Jul 9, 2024
spacemesh/v2alpha1/tx.proto
Outdated
| @@ -22,10 +22,13 @@ message Transaction { | |||
| TRANSACTION_TYPE_UNSPECIFIED = 0; | |||
| TRANSACTION_TYPE_SINGLE_SIG_SEND = 1; | |||
| TRANSACTION_TYPE_SINGLE_SIG_SPAWN = 2; | |||
| TRANSACTION_TYPE_SINGLE_SIG_SELFSPAWN = 3; | |||
| TRANSACTION_TYPE_SINGLE_SIG_SELFSPAWN = 3; // deprecated | |||
There was a problem hiding this comment.
How about using deprecated option?
Suggested change
| TRANSACTION_TYPE_SINGLE_SIG_SELFSPAWN = 3; // deprecated | |
| TRANSACTION_TYPE_SINGLE_SIG_SELFSPAWN = 3 [deprecated = true]; |
There was a problem hiding this comment.
Cool, I didn't know that
spacemesh/v2alpha1/tx.proto
Outdated
Comment on lines
55
to
56
| uint32 vesting_start = 4; | ||
| uint32 vesting_end = 5; |
There was a problem hiding this comment.
What kind of units are these?
There was a problem hiding this comment.
Layer number - added comments
brusherru
approved these changes
Jul 9, 2024
poszu
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.