Fix sync with go-sm api version #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems kinda backwards. I think this job should be run in the go-spacemesh repository when a new version of go-spacemesh is released generating the swagger for the api version that is specified in go mod. To extract the version of a dependency you can do $ go list -m github.com/spacemeshos/api/release/go
github.com/spacemeshos/api/release/go v1.48.0Then clone the api repository of that tag, generate the swagger and upload it where it needs to go. This would then automatically be updated on every release of go-spacemesh 🙂 EDIT: right now one needs to manually run this job after go-sm is released to update the swagger file. |
|
Moved to go-sm spacemeshos/go-spacemesh#6088 |
fasmat
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.