Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvement to the GPG command #699

Closed
wants to merge 1 commit into from
Closed

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Dec 19, 2024

Description of the change

It doesn't work on my machine without this option. I thought I'll add it.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

It doesn't work on my machine without this option. I thought I'll add it.
@adamconnelly adamconnelly temporarily deployed to gpg-improvement - spacelift-user-documentation PR #699 December 19, 2024 12:46 — with Render Destroyed
@peterdeme peterdeme requested a review from a team December 19, 2024 12:47
Copy link
Member

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a strong opinion, but keyservers configuration responsibility should not be on us.
I'm fine if we want to suggest a default one anyway, that's not a big deal 🤷

@peterdeme
Copy link
Contributor Author

@eliecharra fair. I was just confused because the command literally didn't work on my machine 😅

@eliecharra
Copy link
Member

Yeah I guess you don't have any keyserver defined in ~/.gnupg/gpg.conf

@peterdeme
Copy link
Contributor Author

alright

@peterdeme peterdeme closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants