Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stack-settings.md #696

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

akmal-spacelift
Copy link
Contributor

Description of the change

Caused some headache for a customer so adding the clarification to the project root section as well

internal ref: https://spacelift-io.slack.com/archives/C069UG3069W/p1734461795274719?thread_ts=1734460322.527129&cid=C069UG3069W

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

@adamconnelly adamconnelly temporarily deployed to project-root-clarification - spacelift-user-documentation PR #696 December 17, 2024 19:00 — with Render Destroyed
@akmal-spacelift akmal-spacelift requested a review from a team December 17, 2024 19:00
@akmal-spacelift akmal-spacelift merged commit 9510e3b into main Dec 18, 2024
1 check failed
@akmal-spacelift akmal-spacelift deleted the project-root-clarification branch December 18, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants