Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for specifying CLI flags for Ansible integration #350

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

michalg9
Copy link
Contributor

@michalg9 michalg9 commented Sep 27, 2023

Description of the change

Describing ability to specify CLI flags for Ansible.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

@render
Copy link

render bot commented Sep 27, 2023

@michalg9 michalg9 requested review from a team September 27, 2023 07:17
Daniellem97
Daniellem97 previously approved these changes Sep 27, 2023
@peterdeme
Copy link
Contributor

peterdeme commented Sep 27, 2023

@michalg9

docker run --rm -it -v $(PWD):/workdir -w /workdir videah/oxipng docs/assets/screenshots/ansible/ansible_cli_flags.png --opt=4 --preserve --strip=safe

@michalg9 michalg9 merged commit 1cc1a92 into main Sep 27, 2023
1 check passed
@michalg9 michalg9 deleted the CU-862jby5wy-docs-for-specifying-ansible-cli-args branch September 27, 2023 11:14
@jmfontaine
Copy link
Contributor

@peterdeme @michalg9 Instead of pushing unoptimized images, having the check fail, manually running the optimizer, and pushing the optimized images, which is annoying and unnecessarily adds to the size of the repository, I would recommend that you use pre-commit so that all of that happens locally and automatically. See the CONTRIBUTING file for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants