Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to add marketplace agreement through Terraform #22

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kellystuard
Copy link

@kellystuard kellystuard commented Jun 13, 2024

resolves #21

Description of the change

Updates documentation to show how to automatically accept the required marketplace agreement and create the worker pool in a single apply, by using Terraform and dependencies.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The code is formatted properly;

Code review

  • The module version is bumped accordingly;
  • Spacelift tests are passing;
  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@kellystuard
Copy link
Author

Spacelift tests failing; seems to be due to version not being bumped. I believe since it's just a documentation change that isn't part of the release, it would be wrong for me to bump the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to add marketplace agreement through Terraform
1 participant