Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct AWS role #69

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix: use correct AWS role #69

merged 1 commit into from
Oct 14, 2024

Conversation

adamconnelly
Copy link
Contributor

@adamconnelly adamconnelly commented Oct 14, 2024

Description of the change

Updating the workflow to use a new secret to get the role from based on some infra changes.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);
  • Other;

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

Updating the workflow to use a new secret to get the role from based on some infra changes.
@adamconnelly adamconnelly marked this pull request as ready for review October 14, 2024 10:24
@adamconnelly adamconnelly requested a review from a team as a code owner October 14, 2024 10:24
@adamconnelly adamconnelly merged commit d2dfdf7 into main Oct 14, 2024
3 checks passed
@peterdeme peterdeme deleted the adamc/fix-role-arn branch November 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants