Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): publish to community gallery #62

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

peterdeme
Copy link
Collaborator

@peterdeme peterdeme commented Sep 13, 2024

Description of the change

I hope this is enough to make it publish to our new gallery.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@peterdeme peterdeme marked this pull request as ready for review September 13, 2024 16:53
@peterdeme peterdeme requested a review from a team as a code owner September 13, 2024 16:53
@peterdeme peterdeme force-pushed the peterd/azure-use-new-public-gallery branch from 9c97c46 to 4cae142 Compare September 13, 2024 17:07
adamconnelly
adamconnelly previously approved these changes Sep 16, 2024
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but like I mentioned on Slack, I think we need to define ubuntu_20_04 image for the new gallery in infra before this will work.

@peterdeme
Copy link
Collaborator Author

@adamconnelly updated

@peterdeme peterdeme merged commit 673cc48 into main Sep 16, 2024
3 checks passed
@peterdeme peterdeme deleted the peterd/azure-use-new-public-gallery branch September 16, 2024 10:59
peterdeme added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants