-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tools/snp50k/index.html with links to SNP50k markers on WM82.A6 #188
Conversation
In the "main" branch, it looks as though the _themes/jekyll-theme-legumeinfo git submodule already points to the latest commit in the legumeinfo/jekyll-theme-legumeinfo repo. |
It may be that the problem is just on my end, and that the PR is fine as-is. My understanding of submodules is lacking. Here is what I see with
How do I sync _themes/jekyll-theme-legumeinfo to the remote submodule's "main"? If I cd to _themes/jekyll-theme-legumeinfo, I get "HEAD detached". |
Are there any uncommitted changes in _themes/jekyll-theme-legumeinfo? What does
|
@nathanweeks - I think I am back in business now. Earlier today I did this:
and now So, I think this is ready for review & merge, if the changes look OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I'll proffer a Liquid loop to generate all rows for the table (feel free to use or not):
{% assign assemblies = "1,2,4,6" | split: "," %}
{% for assembly in assemblies %}
<tr>
<th><b>Wm82.a{{ assembly }}</b></th>
{% for chromosome in (1..20) %}
{% assign chr = chromosome | prepend: '00' | slice: -2,2 %}
<td><a href="/assets/js/jbrowse/?assembly=Wm82.gnm{{ assembly }}&tracks=Wm82.gnm{{ assembly }}.ann1,Wm82.gnm{{ assembly }}.mrk.SoySNP50K&loc=glyma.Wm82.gnm{{ assembly }}.Gm{{ chr }}:1-1000000" target="_blank">Gm{{ chr }}</a></td>
{% endfor %}
</tr>
{% endfor %}
Thanks. I'll add that. I was also thinking that such a thing would be preferable. |
…map label in collections page.
Added links to JBrowse WM82.A6
Problem -- flagging @nathanweeks or @ChenProm-USDA : I can't see how to update jekyll-theme-legumeinfo.
I have tried: