-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: enable multithreaded sketching to zip file (manysketch) #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluegenes
changed the title
EXP: enable multithreaded manysketch (sketchall) within rust
WIP: enable multithreaded manysketch (sketchall) within rust
Sep 3, 2023
bluegenes
changed the title
WIP: enable multithreaded manysketch (sketchall) within rust
WIP: enable multithreaded sketching to zip file (manysketch)
Sep 4, 2023
bluegenes
changed the title
WIP: enable multithreaded sketching to zip file (manysketch)
MRG: enable multithreaded sketching to zip file (manysketch)
Sep 5, 2023
@ctb ready for review |
nifty! will dig in later, but one request and one suggestion -
well, and a third thought - might be good to start an issue with upgrade suggestions, like "enable protein sketching" or whatever comes to mind. |
* manifest writing working! need to fix format, though * closer but still not right * working manifest!!! * param_str working, except for protein? * upd test; add manifest test * fix moltype manifest write * mult params; ensure only unique param combinations * upd test * add some usage docs * better wording * a few more param checks * keep duplicated md5sum sigs * working csv read, but only using genome_filename * working csv read with dna and protein files * ignore duplicated rows, add prot tests * handle protein ksize *3 * upd doc for csv instead of txt * fix basename for test * force past Ns in dna sequence * eprintln instead of error, given no env_logger * also check csv header * prettier print err * skip incompatible fastas entirely * better reporting * round reporting percentage
… into try-sketch
ctb
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #96.
Enable manysketch to zipfile (that can then be used to make rocksdb index).
This PR adds:
_i
to filenames and make sure it's reflected in the internal_location)Notes:
Usage
To run
manysketch
, you need to build a csv file with columnsname,genome_filename,protein_filename
(fa.csv
, below). You can then run:The output will be written to
fa.zip
You can check if all signatures were written properly with
To modify sketching parameters, use
--param-str
or-p
and provide valid param string(s)