Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update to (prospective) sourmash r0.18.0 #548

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ctb
Copy link
Collaborator

@ctb ctb commented Dec 18, 2024

This PR updates to sourmash core latest, which will be r0.18.0.

  • remove test_fastgather.py::test_bad_against_3, test_index.py:test_index_zipfile_bad, test, which now (correctly) succeed!

TODO:

  • add links to relevant sourmash PRs - better zip file handling, manifest intersection
  • add tests for manifest intersection
  • should we do anything to add a test back for misnamed zip file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant