-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: parallelize loading sketches into memory #292
Conversation
in re preserving ordering of signatures, here's what we have in the sourmash internals doc:
So anyway I think it's fine if ordering isn't preserved when loading :). Do you have any speed benchmarks? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how simple the changes are 😆
Mind if I merge this @bluegenes? I'm running into #268 myself - it's quite noticeable for 400k genomes! |
@ctb - go for it. I just didn't get around to benchmarking, so I really have no idea how much it will help. Would appreciate you dropping the time here, if you're running it! |
optimized (I think) wheel built here:
|
last released version, v0.9.3: 50m 47s of compute, with one thread.
|
This branch: 30m 38s with up to 64 threads (but, realistically, about 2).
|
So I don't see any downsides to this (and I'll update the PR description at the top with the benchmarks) but it's not a panacea :( |
+1 - faster loading
-1 - likely does not preserve ordering?
ref #268
Benchmarks
HG38 entire vs GTDB rs214 @ k=51