Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: fix manysketch naming bug #284

Merged
merged 2 commits into from
Mar 20, 2024
Merged

MRG: fix manysketch naming bug #284

merged 2 commits into from
Mar 20, 2024

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Mar 20, 2024

This bug caused sketch names to be set only for the first sketch for a given file, and not set for any additional sketches. This means, if we were sketching at k=21,k=31,k=51, only the k=21 sketches would have the name properly set.

@bluegenes bluegenes changed the title WIP: fix manysketch naming bug MRG: fix manysketch naming bug Mar 20, 2024
@bluegenes
Copy link
Contributor Author

@ctb ready for review

@bluegenes bluegenes merged commit 34adf84 into main Mar 20, 2024
1 check passed
@bluegenes bluegenes deleted the fix-manysketch-naming branch March 20, 2024 21:22
@ctb ctb mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manysketch does not set name properly for multiple sketches per entry
2 participants