Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: add zip reading to fastmultigather #106

Merged
merged 7 commits into from
Sep 13, 2023
Merged

MRG: add zip reading to fastmultigather #106

merged 7 commits into from
Sep 13, 2023

Conversation

bluegenes
Copy link
Contributor

@bluegenes bluegenes commented Sep 8, 2023

Follow up to #105:

  • Enables sourmash zipfiles to be used as input to fastmultigather.

to do:

Notes:

  • When we build pathlists from zipfiles, internal sketches are extracted to individual files. To prevent excessive and unhelpful warnings, we only warn about individual input files without compatible sketches if the input was not a zipfile.
  • This also means tests need to be different - sig files will be named by their md5 instead of the zipfile filename

Base automatically changed from add-zip-utils to main September 12, 2023 14:41
@ctb ctb changed the title WIP: add zip reading to fast_multigather WIP: add zip reading to fastmultigather Sep 13, 2023
@bluegenes bluegenes changed the title WIP: add zip reading to fastmultigather MRG: add zip reading to fastmultigather Sep 13, 2023
@bluegenes
Copy link
Contributor Author

@ctb ready for review

@bluegenes bluegenes merged commit 072bb34 into main Sep 13, 2023
1 check passed
@bluegenes bluegenes deleted the zip-fastmg branch September 13, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants