Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intersect_manifest fails to match identical Records because of Signature::name() behavior #550

Closed
ctb opened this issue Dec 21, 2024 · 0 comments · Fixed by #548
Closed

intersect_manifest fails to match identical Records because of Signature::name() behavior #550

ctb opened this issue Dec 21, 2024 · 0 comments · Fixed by #548

Comments

@ctb
Copy link
Collaborator

ctb commented Dec 21, 2024

Prior to sourmash r0.18.0, Signature::name() returns either filename() or md5sum(), in that order, if name is not set. This causes a bug (see #538 (comment)) where manifests improperly disagree about whether two Records match when name is not set.

The sourmash behavior was fixed in sourmash-bio/sourmash#3434, which is now released in sourmash r0.18.0.

Fixed by #548, which will be coming soon to a release near you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MRG: update to (prospective) sourmash r0.18.0 sourmash-bio/sourmash_plugin_branchwater
1 participant
@ctb