Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manysketch does not set name properly for multiple sketches per entry #283

Closed
bluegenes opened this issue Mar 20, 2024 · 0 comments · Fixed by #284
Closed

manysketch does not set name properly for multiple sketches per entry #283

bluegenes opened this issue Mar 20, 2024 · 0 comments · Fixed by #284

Comments

@bluegenes
Copy link
Contributor

naming bug likely introduced in #184

set_name likely not working as intended. I think it sets the name for the first signature (e.g. k=21) but not for any subsequent (e.g. k=31,51).

 } else if !set_name {
      sig.set_name(name);
   // sourmash sets filename to last filename if merging fastas
      sig.set_filename(last_filename.as_str());
     set_name = true;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant