Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: improve downsampling behavior on KmerMinHash; fix RevIndex::gather bug around scaled. #3342

Merged
merged 25 commits into from
Oct 15, 2024

Merge branch 'latest' into refactor_rs_downsample

80c3404
Select commit
Loading
Failed to load commit list.
Merged

MRG: improve downsampling behavior on KmerMinHash; fix RevIndex::gather bug around scaled. #3342

Merge branch 'latest' into refactor_rs_downsample
80c3404
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis completed Oct 15, 2024 in 0s

Performance Regression: -16.6%

Summary

❌ 4 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark latest refactor_rs_downsample Change
abund0_ani_ci0 560.6 µs 672.2 µs -16.6%
abund0_ani_ci1 581.4 µs 692.9 µs -16.09%
abund1_ani_ci0 787.2 µs 898.7 µs -12.41%
abund1_ani_ci1 809.7 µs 921.2 µs -12.1%