Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXP: debug/update rocksdb issues with storage #3249

Closed
wants to merge 19 commits into from
Closed

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jul 13, 2024

@ctb
Copy link
Contributor Author

ctb commented Jul 13, 2024

@luizirber how do you feel about adding anyhow to sourmash-rs core? It would help with some of the error improvement/propagation stuff I'm dealing with; see newly added panic!s ;).

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.37%. Comparing base (8c0fde5) to head (df24131).
Report is 72 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3249      +/-   ##
==========================================
+ Coverage   86.75%   92.37%   +5.62%     
==========================================
  Files         137      104      -33     
  Lines       15920    12909    -3011     
  Branches     2728     2728              
==========================================
- Hits        13811    11925    -1886     
+ Misses       1800      675    -1125     
  Partials      309      309              
Flag Coverage Δ
hypothesis-py 25.40% <ø> (ø)
python 92.37% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb
Copy link
Contributor Author

ctb commented Jul 13, 2024

per slack, luiz says:

re anyhow: I usually follow this advice
https://github.com/dtolnay/anyhow?tab=readme-ov-file#comparison-to-thiserror

Use Anyhow if you don't care what error type your functions return, you just want it to be easy. This is common in application code. Use thiserror if you are a library that wants to design your own dedicated error type(s) so that on failures the caller gets exactly the information that you choose.

somewhat same with env_logger: it's for applications, not libs. tho if you're looking for it in tests you can init it there (and make it a dev-dependency)

@ctb ctb closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant