Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: adjust how ANI is calculated in the revindex code. #3218

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Jun 19, 2024

Calculate ANI of matches against original query with f_orig_query and f_match_orig, instead of against f_unique_to_query and f_match.

This fixes the ANI differences between sourmash gather and RocksDB branchwater gather for the columns query_containment_ani, match_containment_ani, max_containment_ani, and average_containment_ani.

Refs:

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (5bde7dc) to head (b5064a5).
Report is 69 commits behind head on latest.

Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3218      +/-   ##
==========================================
- Coverage   86.70%   86.70%   -0.01%     
==========================================
  Files         136      136              
  Lines       15829    15830       +1     
  Branches     2716     2716              
==========================================
  Hits        13725    13725              
- Misses       1794     1795       +1     
  Partials      310      310              
Flag Coverage Δ
hypothesis-py 25.35% <ø> (ø)
python 92.33% <ø> (ø)
rust 62.22% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb ctb added the rust label Jun 19, 2024
@ctb ctb changed the title EXP: adjust how ANI is calculated MRG: adjust how ANI is calculated in the revindex code. Jun 19, 2024
@ctb
Copy link
Contributor Author

ctb commented Jun 19, 2024

Ready for review @bluegenes !

@ctb
Copy link
Contributor Author

ctb commented Jun 19, 2024

(Once this is merged, I will release a new sourmash core, 0.14.1, and then complete the PR here: sourmash-bio/sourmash_plugin_branchwater#361)

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ctb ctb merged commit 3009725 into latest Jun 19, 2024
39 checks passed
@ctb ctb deleted the adjust_ani_calc_gather branch June 19, 2024 13:39
ctb added a commit that referenced this pull request Jun 19, 2024
## [0.14.1] - 2024-06-19

MSRV: 1.65

Changes/additions:

* adjust how ANI is calculated in the revindex code. (#3218)

Updates:

* Bump histogram from 0.10.2 to 0.11.0 (#3216)
* Bump histogram from 0.10.1 to 0.10.2 (#3207)
* Bump statrs from 0.16.1 to 0.17.1 (#3205)
* Bump roaring from 0.10.4 to 0.10.5 (#3206)
* Bump primal-check from 0.3.3 to 0.3.4 (#3208)
* Bump niffler from 2.5.0 to 2.6.0 (#3204)
@@ -44,7 +44,7 @@ md5 = "0.7.0"
memmap2 = "0.9.4"
murmurhash3 = "0.0.5"
needletail = { version = "0.5.1", default-features = false }
niffler = { version = "2.6.0", default-features = false, features = [ "gz" ] }
niffler = { version = "2.4.0", default-features = false, features = [ "gz" ] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you need to revert this for the plugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I figured no harm done since it will just come up again with dependabot ;))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but I will document next time I stumble across the error.

@ctb ctb mentioned this pull request Jun 29, 2024
15 tasks
ctb added a commit that referenced this pull request Jun 29, 2024
Release candidate testing:
- [ ] Command line tests pass for a release candidate
- [ ] All eight release candidate wheels are built

Releasing to PyPI:

- [ ] RC tag(s)s deleted on github
- [ ] Release tag cut
- [ ] Release notes written
- [ ] All eight release wheels built
- [ ] Release wheels uploaded to pypi
- [ ] tar.gz distribution uploaded to pypi

After release to PyPI and conda-forge/bioconda packages built:

- [ ] [PyPI page](https://pypi.org/project/sourmash/) updated
- [ ] Zenodo DOI successfully minted upon new github release - [see
search
results](https://zenodo.org/search?page=1&size=20&q=sourmash&sort=mostrecent)
- [ ] `pip install sourmash` installs the correct version
- [ ] [conda-forge
sourmash-minimal-feedstock](https://github.com/conda-forge/sourmash-minimal-feedstock)
has updated `sourmash-minimal` to the correct version
- [ ] `mamba create -n smash-release -y sourmash` installs the correct
version

Optional but recommended:

- [ ] PR submitted to update pyodide version
- [ ] PR submitted to update spack version

---

## Release notes

Minor new features:

* check `select` parameters; enforce types when building manifests
(#3212)
* patch-fix `sig extract` to no longer create empty zips (#3214)

Bug fixes:

* adjust how ANI is calculated in the revindex code. (#3218)

Cleanup and documentation updates:

* final updates for 2024 JOSS publication (#3225)
* Improve JOSS paper affiliations (#3224)
* fix DOI for Rahman Hera paper in JOSS pub. (#3221)
* upd citations, minor text (#3220)

Developer updates:

* bump sourmash core version to 0.14.1 (#3219)
* bump version to 4.8.10-dev (#3211)

Dependabot updates:

- Bump proptest from 1.4.0 to 1.5.0 (#3222)
- [pre-commit.ci] pre-commit autoupdate (#3223)
- [pre-commit.ci] pre-commit autoupdate (#3003)
- Bump histogram from 0.10.2 to 0.11.0 (#3216)
- Bump pypa/cibuildwheel from 2.19.0 to 2.19.1 (#3217)
- Bump histogram from 0.10.1 to 0.10.2 (#3207)
- Bump statrs from 0.16.1 to 0.17.1 (#3205)
- Bump roaring from 0.10.4 to 0.10.5 (#3206)
- Bump primal-check from 0.3.3 to 0.3.4 (#3208)
- Bump niffler from 2.5.0 to 2.6.0 (#3204)
- Bump pypa/cibuildwheel from 2.18.1 to 2.19.0 (#3202)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants