Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: update more text to suggest sourmash tax / deprecate sourmash lca #2784

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Sep 25, 2023

This PR further updates the command-line docs and the classifying-signatures docs to deprecate LCA.

Fixes #2779

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #2784 (6b51482) into latest (7b0da53) will increase coverage by 6.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2784      +/-   ##
==========================================
+ Coverage   85.94%   92.85%   +6.90%     
==========================================
  Files         130      104      -26     
  Lines       14807    12424    -2383     
  Branches     2621     2621              
==========================================
- Hits        12726    11536    -1190     
+ Misses       1780      587    -1193     
  Partials      301      301              
Flag Coverage Δ
hypothesis-py 25.82% <ø> (ø)
python 92.85% <ø> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor Author

ctb commented Sep 26, 2023

Ready for review @sourmash-bio/devs

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ctb ctb merged commit 8e63153 into latest Sep 26, 2023
21 checks passed
@ctb ctb deleted the more/remove_lca branch September 26, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update text in classifying-signatures.md around Breaking down metagenomic samples
2 participants