Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: add __all__ to sig/__main__.py #2778

Merged
merged 1 commit into from
Sep 25, 2023
Merged

MRG: add __all__ to sig/__main__.py #2778

merged 1 commit into from
Sep 25, 2023

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Sep 24, 2023

This change limits what is imported with from sourmash.sig.__main__ import *.

Fixes #2714

@ctb
Copy link
Contributor Author

ctb commented Sep 24, 2023

ready for review @sourmash-bio/devs

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #2778 (876a616) into latest (d1be0e0) will increase coverage by 6.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #2778      +/-   ##
==========================================
+ Coverage   85.91%   92.85%   +6.93%     
==========================================
  Files         130      104      -26     
  Lines       14811    12424    -2387     
  Branches     2621     2621              
==========================================
- Hits        12725    11536    -1189     
+ Misses       1785      587    -1198     
  Partials      301      301              
Flag Coverage Δ
hypothesis-py 25.82% <100.00%> (+<0.01%) ⬆️
python 92.85% <100.00%> (+<0.01%) ⬆️
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/sourmash/sig/__main__.py 93.83% <100.00%> (+<0.01%) ⬆️

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ctb ctb merged commit 256a705 into latest Sep 25, 2023
21 checks passed
@ctb ctb deleted the add/sig_all branch September 25, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

define __all__ in src/sourmash/sig/__main__.py
2 participants