-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: adjust documentation to recommend tax
over lca
for taxonomic analysis
#2777
Conversation
ready for review @bluegenes |
Codecov Report
@@ Coverage Diff @@
## latest #2777 +/- ##
==========================================
+ Coverage 85.91% 92.85% +6.93%
==========================================
Files 130 104 -26
Lines 14812 12423 -2389
Branches 2621 2621
==========================================
- Hits 12726 11535 -1191
+ Misses 1785 587 -1198
Partials 301 301
Flags with carried forward coverage won't be shown. Click here to find out more. see 27 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and provides some good context for why gather
--> tax
over lca
.
Only thought - do you want to add a sentence on where LCA is still useful? E.g. tracking down individual k-mers/sequences, exploratory work, etc?
…o doc/tax_over_lca
Added in #2777 (review) (I had originally put in something like that, and then removed as confusing, so your prompt was a nice reality check!) |
This PR adds cautionary notes to the command line docs, and updates the information on classifying signatures to suggest using tax instead of LCA, and even explains why :).
There is more work to be done - we need to add more tutorials, and adjust the language in classifying-signatures around gather and LCA - but this is a nice standalone PR!
Fixes #2562
Fixes #2772
Fixes #2773
Adds information from #2760
Addresses #2535