Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: avoid compressing sig files in directory output twice #2752

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Sep 6, 2023

Fixes #2751

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2752 (4656ebe) into latest (038a37b) will increase coverage by 6.94%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           latest    #2752      +/-   ##
==========================================
+ Coverage   85.89%   92.83%   +6.94%     
==========================================
  Files         130      104      -26     
  Lines       14789    12401    -2388     
  Branches     2614     2614              
==========================================
- Hits        12703    11513    -1190     
+ Misses       1785      587    -1198     
  Partials      301      301              
Flag Coverage Δ
hypothesis-py 25.80% <0.00%> (ø)
python 92.83% <100.00%> (ø)
rust ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/sourmash/save_load.py 92.30% <100.00%> (ø)

... and 26 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ctb
Copy link
Contributor Author

ctb commented Sep 6, 2023

ready for review & merge @sourmash-bio/devs

@ctb ctb merged commit d4a1b45 into latest Sep 7, 2023
21 checks passed
@ctb ctb deleted the fix_2751 branch September 7, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SaveSignatures_Directory writes 2x-compressed signatures
2 participants