Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECO-4936] Implement the ability to attach and detach a room #16

Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow compiler to infer CheckedContinuation error type
I didn’t know about this feature in 646c220.
lawrence-forooghian committed Sep 3, 2024
commit fa0e7be3717188c3b35574cf4eae9a3113c8785f
2 changes: 1 addition & 1 deletion Sources/BuildTool/ProcessRunner.swift
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ enum ProcessRunner {
// There’s probably a better way to implement these, which doesn’t involve having to use a separate dispatch queue. There’s a proposal for a Subprocess API coming up in Foundation which will marry Process with Swift concurrency.

static func run(executableName: String, arguments: [String]) async throws {
try await withCheckedThrowingContinuation { (continuation: CheckedContinuation<Void, Swift.Error>) in
try await withCheckedThrowingContinuation { (continuation: CheckedContinuation<Void, _>) in
queue.async {
let process = Process()
process.executableURL = URL(fileURLWithPath: "/usr/bin/env")