Add performance analysis tool #167
Conversation
contrib/perf.cc
Outdated
| static long perf_event_open(struct perf_event_attr *hw_event, pid_t pid, | ||
| int cpu, long group_fd, unsigned long flags) { | ||
| long fd; | ||
| fd = syscall(SYS_perf_event_open, hw_event, pid, cpu, group_fd, flags); |
There was a problem hiding this comment.
I wonder if we should not test that hw_event is not empty.
There was a problem hiding this comment.
It's only called within this one file and guaranteed to be initialized correctly, so I don't think this is a concern.
|
Also as a reader/user I would like to have a readme with a few explanations, a few snippets. Ideally we would like to have a run job on the CI just to illustrate it :) Great job @michaelmior 😍 |
|
Any idea why CI is failing on Linux? (I'd expect this for macOS/Windows.) |
michaelmior
force-pushed
the
perf
branch
2 times, most recently
from
4cce79a to
84a6540
Compare
|
@tony-go Fair enough with the suggestion of examples. I didn't see this with any existing tools which is why I didn't add anything. Any suggestion where such docs should live? |
|
Yeah, I would deal with README + CI runs for these kind of things in a separate PR if any, as we are not doing it for any of them. |
michaelmior
force-pushed
the
perf
branch
3 times, most recently
from
72be042 to
b20008d
Compare
Signed-off-by: Michael Mior <[email protected]>
|
@jviotti There were a couple formatting issues I corrected, but now all the CI failures are due to |
|
Ah, it's the benchmark comments. I guess they can't post if they are coming from PRs 😓 Let me merge as-is and I'll try to fix it later |
|
I made an upstream issue here: benchmark-action/github-action-benchmark#279. Maybe we are missing some setting or something. |
|
Strange! I would have said that would be because you need to manually specify a GitHub token, but you're already doing that. |
No description provided.