Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitindex: disable gogit optimization by default #870

Merged
merged 1 commit into from
Dec 3, 2024
Merged

gitindex: disable gogit optimization by default #870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions gitindex/index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ package gitindex

import (
"bytes"
"cmp"
"context"
"errors"
"fmt"
Expand Down Expand Up @@ -408,9 +409,10 @@ func indexGitRepo(opts Options, config gitIndexConfig) (bool, error) {
opts.BuildOptions.RepositoryDescription.Source = opts.RepoDir

var repo *git.Repository
// TODO: remove this feature flag once we test this on a large-scale instance.
legacyRepoOpen := os.Getenv("ZOEKT_DISABLE_GOGIT_OPTIMIZATION")
if b, err := strconv.ParseBool(legacyRepoOpen); b && err == nil {
// TODO: this now defaults to on since we found a bug in it. Once we have
// fixed openRepo default to false.
legacyRepoOpen := cmp.Or(os.Getenv("ZOEKT_DISABLE_GOGIT_OPTIMIZATION"), "true")
if b, err := strconv.ParseBool(legacyRepoOpen); b || err != nil {
repo, err = git.PlainOpen(opts.RepoDir)
if err != nil {
return false, fmt.Errorf("git.PlainOpen: %w", err)
Expand Down
Loading