Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive: add cody and golang repo to e2e rank corpus #696

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

keegancsmith
Copy link
Member

Additionally we add many queries we are tracking.

Test Plan: go test

Based on #695

@keegancsmith keegancsmith requested a review from a team November 15, 2023 12:26
Copy link
Member

@stefanhengl stefanhengl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this test super brittle IE we will have to update it all the time? Should we move to something that just tracks the order of files or a derived metric?

@keegancsmith
Copy link
Member Author

it will require updating often, however part of reviewing code changes will then be eyeballing the changes to this file. That seems like a good thing? Also updating is as easy as passing the -update flag. WDYT? Would you prefer excluding debug output maybe so it only changes when result order changes?

Base automatically changed from k/integration to main November 20, 2023 12:19
Additionally we add many queries we are tracking.

Test Plan: go test
@keegancsmith keegancsmith merged commit e9dcbbb into main Nov 20, 2023
6 of 7 checks passed
@keegancsmith keegancsmith deleted the k/integration-more branch November 20, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants