Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve query script output #668

Closed
wants to merge 2 commits into from
Closed

Improve query script output #668

wants to merge 2 commits into from

Conversation

jtibshirani
Copy link
Member

@jtibshirani jtibshirani commented Oct 19, 2023

Small improvements to the Zoekt query script:

  • Switch to chunk matches instead of line matches to better represent
    Sourcegraph search
  • Make the results more readable by pulling out the filename and limiting the
    number of matches

@jtibshirani jtibshirani marked this pull request as ready for review October 19, 2023 17:10
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should hide these changes in behaviour behind a flag. The zoekt cmd is used by some people for local search, so they probably expect grep like output.

@jtibshirani
Copy link
Member Author

Oh oops, I thought this was just a testing script :) Instead of using a feature flag, what would you think of forking this into a script for testing ranking? I'd expect the changes to add up -- using FlushWallTime, the ability to pass a list of queries + relevant files and calculate an aggregate score, etc.

@keegancsmith
Copy link
Member

Yeah lets add a new command.

@keegancsmith keegancsmith deleted the jtibs/zoekt-script branch January 16, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants