scoring: handle scip-ctags kinds #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are likely more that we are missing. We only briefly looked at golang, likely other languages are also affected. The regression is scip-ctags returning different values for kind. Will follow-up with a more comprehensive workaround until scip-ctags issues are resolved. Test Plan: manually tested queries like "test server" against the golang repo until the test server struct was the top result. Co-authored-by: Stefan Hengl <[email protected]>
keegancsmith
force-pushed
the
k/scoring
branch
from
4fc31b6 to
b9c0385
Compare
stefanhengl
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are likely more that we are missing. We only briefly looked at golang, likely other languages are also affected. The regression is scip-ctags returning different values for kind.
Will follow-up with a more comprehensive workaround until scip-ctags issues are resolved.
Test Plan: manually tested queries like "test server" against the golang repo until the test server struct was the top result.
Co-authored-by: @stefanhengl
See https://github.com/sourcegraph/sourcegraph/issues/57659