Diff zoekt git settings #635
Open
+60
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
have CloneRepo return the repo so it gets re-indexed
keegancsmith
reviewed
Aug 3, 2023
| outBuf := &bytes.Buffer{} | ||
| errBuf := &bytes.Buffer{} | ||
| cmd.Stdout = outBuf | ||
| cmd.Stderr = errBuf |
Comment on lines
+82
to
+85
| settingsToUpdate, err := getZoektSettingsToUpdate(repoDest, settings, keys) | ||
| if err != nil { | ||
| return false, err | ||
| } |
There was a problem hiding this comment.
if this fails do you maybe wanna fallback to just updating everything?
There was a problem hiding this comment.
Yeah sure that makes sense, good idea
Sure, I'll give it a shot! thanks for taking a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an optimization on top of what I introduced in #600.
Rather than always updating the zoekt settings for every repo, which can be at least 10 git calls per repo (10 is the current number of zoekt settings we store), we instead get all
zoekt-*settings with one call, and then only make calls to update the changed values. I remember testing, and the code handled new and deletedzoekt-*keys fine. This is just a constant speedup, but it really limits the number of git calls and IO we perform, especially with larger sets of repos.We also make another change, in that if the zoekt-settings are updated, we return the
repoDestwhich triggers a re-index right away.