This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
SCIP ctags: add kinds for C#, Python, Ruby #57879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some differences with universal-ctags, most of which are positive. C-sharp
Python
Ruby
|
jtibshirani
commented
Oct 24, 2023
docker-images/syntax-highlighter/crates/scip-syntax/queries/c_sharp/scip-tags.scm
Outdated
Show resolved
Hide resolved
olafurpg
reviewed
Oct 25, 2023
docker-images/syntax-highlighter/crates/scip-syntax/src/ts_scip.rs
Outdated
Show resolved
Hide resolved
olafurpg
reviewed
Oct 25, 2023
...ighlighter/crates/scip-syntax/src/snapshots/scip_syntax__test__scip_snapshot_globals.cs.snap
Show resolved
Hide resolved
|
@jtibshirani I've created a PR to add the missing kinds you noted in sourcegraph/scip#209 |
Thank you @varungandhi-src ! I guess I'll wait for a new SCIP release, then update the PR with the new version + kinds. |
|
@jtibshirani I've published a new release v0.3.1 |
|
This is ready for another look. Summary of changes:
|
olafurpg
approved these changes
Oct 26, 2023
jtibshirani
added a commit
that referenced
this pull request
Nov 1, 2023
Added more fine-grained kinds for C#, Python, and Ruby to better match the universal-ctags output. Addresses https://github.com/sourcegraph/sourcegraph/issues/57659
keegancsmith
pushed a commit
that referenced
this pull request
Nov 2, 2023
* SCIP syntax: add more kinds for go ctags (#57806) This change adds fine-grained kinds to the Go ctags output. Specific changes: * Split `type` into `interface`, `struct`, and `typealias` * Map struct members to `field` instead of `variable` Universal ctags does not have a clear spec, and some languages use different names for the same kind. So my strategy is not to match universal ctags exactly, but just to capture the correct SCIP kinds. Clients need to handle the fact that the kind names can be different. * SCIP ctags: add kinds for C#, Python, Ruby (#57879) Added more fine-grained kinds for C#, Python, and Ruby to better match the universal-ctags output. Addresses https://github.com/sourcegraph/sourcegraph/issues/57659 * Add scip-ctags kinds for js, ts, and rust (#57899) * SCIP ctags: use MethodSpec kind for Go (#57929) Now that MethodSpec is available in SCIP, we can use it in the Go SCIP ctags output. * SCIP ctags: add kinds for Kotlin (#57998) Improved ctags kind output for Kotlin: * Split type into class, interface, object, and enum * Split variable into enumMember, constant, and property * Add type alias * Fix snapshot tests by adding back trailing whitespace Our precommit hook removes trailing whitespace, but the generated snapshots include it. --------- Co-authored-by: Auguste Rame <[email protected]>
vovakulikov
pushed a commit
that referenced
this pull request
Dec 12, 2023
Added more fine-grained kinds for C#, Python, and Ruby to better match the universal-ctags output. Addresses https://github.com/sourcegraph/sourcegraph/issues/57659
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more fine-grained kinds for C#, Python, and Ruby to better match the universal-ctags output.
Addresses https://github.com/sourcegraph/sourcegraph/issues/57659
Test plan