Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix protoc-gen-rs installation error #298

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

varungandhi-src
Copy link
Contributor

@varungandhi-src varungandhi-src commented Dec 17, 2024

I'm not 100% sure as to why --locked works given that
there is no Cargo.lock either at the root of this repo
or in the rust-protobuf repo, but it seems to fix the
installation error where a dependency 'home v0.5.11'
gets picked up which ends up requiring Rust 1.81+

I saw a failure in an unrelated PR earlier here:
https://github.com/sourcegraph/scip/actions/runs/12357387613/job/34485511480?pr=297

Test plan

Check that CI passes

I'm not 100% sure as to why --locked works given that
there is no Cargo.lock either at the root of this repo
or in the rust-protobuf repo, but it seems to fix the
installation error where a dependency 'home v0.5.11'
gets picked up which ends up requiring Rust 1.81+
@varungandhi-src varungandhi-src merged commit 23b1855 into main Dec 17, 2024
1 check passed
@varungandhi-src varungandhi-src deleted the vg/fix-plugin-error branch December 17, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant