Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add DESIGN.md #289

Merged
merged 2 commits into from
Oct 24, 2024
Merged

docs: Add DESIGN.md #289

merged 2 commits into from
Oct 24, 2024

Conversation

varungandhi-src
Copy link
Contributor

Fixes GRAPH-966

Test plan

n/a

Copy link
Member

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

DESIGN.md Outdated Show resolved Hide resolved
DESIGN.md Show resolved Hide resolved
DESIGN.md Show resolved Hide resolved
DESIGN.md Outdated Show resolved Hide resolved
DESIGN.md Outdated Show resolved Hide resolved
@varungandhi-src
Copy link
Contributor Author

varungandhi-src commented Oct 24, 2024

Addressed all the existing review comments; merging now. Can address follow-up comments/questions later.

@varungandhi-src varungandhi-src merged commit b469406 into main Oct 24, 2024
1 check passed
@varungandhi-src varungandhi-src deleted the vg/scip-design branch October 24, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants