-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add running rust tests #141
base: main
Are you sure you want to change the base?
Conversation
@@ -16,7 +16,42 @@ jobs: | |||
- uses: ./.github/actions/asdf | |||
with: | |||
rust: true | |||
- run: cargo check | |||
working-directory: bindings/rust | |||
- name: Cache cargo registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we move over to the sparse registry protocol, this might not be needed.
- run: cargo check | ||
working-directory: cmd/tests/reprolang | ||
rust-bindings-test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we directly use https://github.com/Swatinem/rust-cache instead of having this custom code with key-specificity etc here?
uses: actions/cache@v2 | ||
with: | ||
path: .bin | ||
key: ${{ runner.os }}-bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems insufficient, as the key won't be invalidated when the dev/proto-generate.sh
file changes (as one example).
Enable running rust tests in CI
Test plan