Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add running rust tests #141

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ci: add running rust tests #141

wants to merge 3 commits into from

Conversation

tjdevries
Copy link
Contributor

Enable running rust tests in CI

Test plan

  • Green tests (now actually running cargo test)

@@ -16,7 +16,42 @@ jobs:
- uses: ./.github/actions/asdf
with:
rust: true
- run: cargo check
working-directory: bindings/rust
- name: Cache cargo registry
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we move over to the sparse registry protocol, this might not be needed.

- run: cargo check
working-directory: cmd/tests/reprolang
rust-bindings-test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we directly use https://github.com/Swatinem/rust-cache instead of having this custom code with key-specificity etc here?

uses: actions/cache@v2
with:
path: .bin
key: ${{ runner.os }}-bin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems insufficient, as the key won't be invalidated when the dev/proto-generate.sh file changes (as one example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants