Skip to content

Commit

Permalink
TypeScript: tweak tsc and protoc-gen-ts versions (#193)
Browse files Browse the repository at this point in the history
* TypeScript: tweak tsc and protoc-gen-ts versions

Attempt to resolve #149

* Use `tsc --force` to force typechecking

See https://www.typescriptlang.org/docs/handbook/project-references.html#caveats

> you may need to run a --force build after certain source control
> operations depending on whether your source control tool preserves
> timestamps between the local copy and the remote copy

* Reformat

* Re-generate bindings
  • Loading branch information
olafurpg authored Jul 24, 2023
1 parent 860dae2 commit 476e877
Show file tree
Hide file tree
Showing 6 changed files with 467 additions and 96 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/typescript.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ jobs:
with:
js: true
- run: yarn install
- name: Check TypeScript
run: ./node_modules/.bin/tsc -b bindings/typescript
- name: Typecheck TypeScript
run: yarn run build
4 changes: 2 additions & 2 deletions bindings/typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
},
"devDependencies": {
"@types/google-protobuf": "3.15.6",
"protoc-gen-ts": "0.8.5",
"typescript": "^4.7.4"
"protoc-gen-ts": "0.8.6",
"typescript": "^4.9.0"
},
"comment": [
"protoc-gen-ts is pinned to 0.8.1 because there is a breaking change in ",
Expand Down
Loading

0 comments on commit 476e877

Please sign in to comment.