EEB 12: Ability to select multiple, some general improvements #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the logos from the topbar to the about page - Make use of the embo logo to make it clear eeb is an embo initiative - Slightly change the style of the topbar and remove the for developers page - Change some wording - Use the new colors
…eme in the list item view
- add the filter panel - on initial load, trigger the default get - remove now unnecessary logic around loading and tabs/store names
The search and the by reviewing service components should now use the new model (paging, query, reviewed by etc.). On change, the behaviour should now be that we trigger an update. Also includes some overall design updates
Use the new model to populate the pagination and records. Includes some tooltip transition changes, missed in previous PRs, and some various small wording and style changes
Search no longer a page, remove reviewer subpaths - they are no longer needed
Remove the files that we no longer need (both components and obsolete store scripts), remove imports using them
…he SourceData website
# Conflicts: # frontend/src/components/filtering/by-reviewing-service.vue # frontend/src/components/highlights/index.vue # frontend/src/layouts/top-nav-bar.vue
- Add multiple option to the chip group - Use the modified store - Remove the about for reviewers from the panel, as it doesn't make sense to have it there anymore
- the reviewers are now attached to each item - when clicked they appear as dialogs
|
Remove the slug map, remove default query params, the API know how to deal with absences |
|
2 issues from our code review:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.