Add rotation operations to BitvectorFormulaManager #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests seem to pass, but Princess is very slow in the |
leventeBajczi
changed the title
|
Yes, even in the AppVeyor the test experienced a timeout with princess. I'll disable it. |
kfriedberger
added a commit
that referenced
this pull request
Mar 24, 2024
…ely support it. This commit replaces #362.
|
The idea to use mod/rem for computing the shift is very good. Princess is quite slow for BV theory, and BV-rotation seems to be beyond its limits, for now. I will close this PR without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #360, this PR
addsenhances the rotateRight and rotateLeft operations in the bitvector formula manager.I added implementations for solvers that do not directly support rotation-by-bitvector, by using shift operations. Therefore, all bitvector-supporting solvers can also use rotation now.